Bugfix: add missing stdlib.h include for rand() usage in ecma-builtin-math.c #2144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-math.c JerryScript-DCO-1.0-Signed-off-by: Martijn The [email protected]
martijnthe
force-pushed
the
add-missing-stdlib-include
branch
from
b47acb0 to
27906f9
Compare
rerobika
reviewed
Dec 8, 2017
| @@ -14,6 +14,7 @@ | |||
| */ | |||
|
|
|||
| #include <math.h> | |||
| #include <stdlib.h> | |||
There was a problem hiding this comment.
If I'm right, stdlib.h comes from this header, which will be included later.
There was a problem hiding this comment.
Ah, you're right, thanks!
The problem is in our stdlib.h header, it's missing rand.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rand ()is being used inecma-builtin-math.c, but thestdlib.hheader is not being included.